Changeset 976

Timestamp:

05/09/08 23:42:10 (7 months ago)

Author:

swiss

Message:

The GMT offset was not being stored within the session because session files can get locked when multiple pages are accessing it (when music is playing there are two concurrent pages being requested - the "Now Playing" screen and the streaming page). It is also worth noting that the session variables only gets written when the page ends (which is a long time for the streaming page)

To get around this, the GMT offset is saved to the database instead of the session.

I've also added a "modified" column to both the sys and user preferences tables which gets updated with the time that the preference was last updated. This is then used for the GMT offset to ensure that we only use it if it was calculated less than 24 horus ago so that changes in timezone (eg: in/out of DST) are picked up.

Refs #128.

Files:

• trunk/swisscenter/base/prefs.php (modified) (4 diffs)
• trunk/swisscenter/base/utils.php (modified) (3 diffs)
• trunk/swisscenter/database/patch_0019.sql (added)

trunk/swisscenter/base/prefs.php

@@ -12 +12 @@
- // ----------------------------------------------------------------------------------
-
+ function get_user_pref_modified_date( $pref, $user_id = '' )
+ {
+   if ($user_id == '')
+     $user_id = get_current_user_id();
+
+   $result = db_value("select modified from user_prefs where user_id = ".$user_id." and name='".strtoupper($pref)."'");
+
+   if (!$result || is_null($result))
+     return false;
+   else 
+     return $result;
+ }
+ 
- function get_user_pref( $pref, $default = '', $user_id = '')
- {
@@ -34 +47 @@
-   {
-     db_sqlcommand("delete from user_prefs where name='".strtoupper($name)."' and user_id=".$user);
-
+, "MODIFIED"=>db_datestr()
-
-     if (!$result)
@@ -48 +61 @@
- // SYSTEM preferences
- // ----------------------------------------------------------------------------------
+
+ function get_sys_pref_modified_date( $pref )
+ {
+   $result = db_value("select modified from system_prefs where name='".strtoupper($pref)."'");
+
+   if (!$result || is_null($result))
+     return false;
+   else 
+     return $result;
+ }
-
- function get_sys_pref( $pref, $default = '' )
@@ -65 +88 @@
-   {
-     db_sqlcommand("delete from system_prefs where name='".strtoupper($name)."'");
-
+, "MODIFIED"=>db_datestr()
-  
-     if (!$result)

trunk/swisscenter/base/utils.php

@@ -476 +476 @@
-function gmt_time()
-{ 
-
-
+
+
+
+
+
-    // Get the GMT time from a web service
-    send_to_log(6,'Attempting to get GMT Standard Time from a web service');
@@ -489 +492 @@
-      $date = str_replace('T',' ',$date);
-      $time = strtotime($date);
-
-
+
+
+
-    }
-    else
@@ -503 +507 @@
-  else
-  {
-_SESSION['GMT Offset']
+offset
-    send_to_log(6,'Using previously stored GMT time',date('r',$time));
-  }