Changeset 6

Timestamp:

06/01/07 03:26:26 (2 years ago)

Author:

major

Message:

Massive changes... output filtering, usage information, and temporary table corrections with regards to max memory calculations

Files:

• mysqltuner.pl (modified) (16 diffs)

mysqltuner.pl

@@ -3 +3 @@
-use warnings;
-use diagnostics;
+use Getopt::Long;
+
+# Set defaults
+my %opt = (
+        "nobad" => 0,
+        "nogood" => 0,
+        "noinfo" => 0,
+        "notitle" => 0,
+    );
+
+# Gather the options from the command line
+GetOptions(\%opt,
+        'nobad',
+        'nogood',
+        'noinfo',
+        'notitle',
+        'help',
+    );
+
+if (defined $opt{'help'} && $opt{'help'} == 1) { usage(); }
+
+sub usage {
+    print "\n".
+        "    MySQL High Performance Tuning Script\n".
+        "    Bug reports, feature requests, and downloads at http://mysqltuner.com/\n".
+        "    Maintained by Major Hayden (major.hayden\@rackspace.com)\n\n".
+        "    Important Usage Guidelines:\n".
+        "       To run the script with the default options, run the script without arguments\n".
+        "       Allow MySQL server to run for at least 24-48 hours before trusting suggestions\n".
+        "       Some routines may require root level privileges (script will provide warnings)\n\n".
+        "    Output Options:\n".
+        "       --nogood        Remove OK responses\n".
+        "       --nobad         Remove negative/suggestion responses\n".
+        "       --noinfo        Remove informational responses\n".
+        "       --notitle       Remove section title headers\n".
+        "\n";
+    exit;
+}
-
-# CONFIGURATION ITEMS
@@ -11 +49 @@
-
-sub goodprint {
+    if ($opt{nogood} == 1) { return 0; }
-    my $text = shift;
-    print $good." ".$text;
@@ -16 +55 @@
-
-sub infoprint {
+    if ($opt{noinfo} == 1) { return 0; }
-    my $text = shift;
-    print $info." ".$text;
@@ -21 +61 @@
-
-sub badprint {
+    if ($opt{nobad} == 1) { return 0; }
-    my $text = shift;
-    print $bad." ".$text;
+}
+
+sub titleprint {
+    if ($opt{notitle} == 1) { return 0; }
+    my $text = shift;
+    print $text;
-}
-
@@ -201 +248 @@
-
-sub check_memory {
-
+title
-    # The purpose of this section is to make sure you're not going to end up in swap or crashing the box
-    # by having buffers that are set too large
@@ -235 +282 @@
-    #   query_cache_size - holds query results (default 0) [still allocated when query_cache_type = 0]
-    my $query_cache_size = (defined $myvar{'query_cache_size'}) ? $myvar{'query_cache_size'} : 0 ;
+    #   max_heap_table_size / tmp_table_size - hold temporary table data from queries
+    #   ** The effective temporary table size is the smaller number between these two
+    my $eff_tmp_table_size;
+    if ($myvar{'tmp_table_size'} > $myvar{'max_heap_table_size'}) {
+        $eff_tmp_table_size = $myvar{'max_heap_table_size'};
+    } else {
+        $eff_tmp_table_size = $myvar{'tmp_table_size'};
+    }
-    #
-    # GLOBAL BUFFER CALCULATIONS:
-
+ + $eff_tmp_table_size
-    #
-    # FINAL BUFFER/MEMORY CALCULATIONS:
@@ -255 +310 @@
-            ") of physical memory (".hr_bytes($physical_memory).")\n";
-    }
+    infoprint "This memory total above is when MySQL is at absolute full load\n";
-}
-
-sub check_slow_queries {
-
+title
-    # If the server hasn't received any queries, then we can't calculate a slow query percentage
-    if ($mystat{'Questions'} > 0) {
@@ -287 +343 @@
-
-sub check_connections {
-
+title
-    # We're looking at two things here:
-    #   How many connections have been used so far and how close is the connection limit?
@@ -316 +372 @@
-
-sub check_key_buffer {
-
+title
-    my $myisamindexes;
-    if ($mysqlvermajor < 5) {
@@ -376 +432 @@
-
-sub check_query_cache {
-
+title
-    # If query cache support isn't compiled into MySQL, we fail here
-    if (!defined $myvar{'have_query_cache'}) {
@@ -428 +484 @@
-
-sub check_sort {
-
+title
-    # SORTING VARIABLES/STATUS:
-    #   read_rnd_buffer_size - sorts are read from this buffer after the sort is complete, helps ORDER BY
@@ -454 +510 @@
-
-sub check_join {
-
+title
-    # JOIN VARIABLES/STATUS:
-    #   join_buffer_size - buffer used to join tables when indexes can't be utilized
@@ -473 +529 @@
-
-sub check_temporary_tables {
-
+title
-    # TEMPORARY TABLE VARIABLES/STATUS:
-    #   Created_tmp_disk_tables - number of temporary tables created on disk
@@ -496 +552 @@
-
-sub check_other_buffers {
-
+title
-    #  bulk_insert_buffer_size = buffer for large inserts (default: 8M)
-    infoprint "Your bulk_insert_buffer_size is ".hr_bytes_rnd($myvar{'bulk_insert_buffer_size'}).
@@ -503 +559 @@
-
-sub performance_options {
-
+title
-    # concurrent_insert = enables simultaneous insert/select on MyISAM tables w/o holes
-    # It's ON/OFF in MySQL 4.1 and 0/1 in MySQL 5.x
@@ -516 +572 @@
-# BEGIN 'MAIN'
-# ---------------------------------------------------------------------------
-
+
+
-mysql_install_ok;               # Check to see if MySQL is installed
-os_setup;                       # Set up some OS variables