Changeset 19

Timestamp:

10/16/07 01:45:09 (1 year ago)

Author:

major

Message:

* Adjusted infoprint to use asterisks (cosmetic)
* Per-thread/global buffer counts are now displayed
* Key buffer increases are only recommended if the buffer is smaller than total indexes and key buffer hit rate is < 95%
* Dropped max_seeks_for_key checks
* Temporary table size increases are not recommended over 256M
* Aborted connection calculation and recommendation adjustments

Files:

• mysqltuner.pl (modified) (6 diffs)

mysqltuner.pl

@@ -69 +69 @@
-    $good = "[\e[00;32mOK\e[00m]";
-    $bad = "[\e[00;31m!!\e[00m]";
---
+**
-} else {
-    $good = "[OK]";
@@ -392 +392 @@
-
-    # Memory usage
+    infoprint "Total buffers per thread: ".hr_bytes($mycalc{'per_thread_buffers'})."\n";
+    infoprint "Total global buffers: ".hr_bytes($mycalc{'server_buffers'})."\n";
-    if ($mycalc{'pct_physical_memory'} > 85) {
-        badprint "Maximum possible memory usage: ".hr_bytes($mycalc{'total_possible_used_memory'})." ($mycalc{'pct_physical_memory'}% of installed RAM)\n";
@@ -426 +428 @@
-        badprint "None of your MyISAM tables are indexed - add indexes immediately\n";
-    } else {
-
+ && $mycalc{'pct_keys_from_mem'} < 95
-            badprint "Key buffer size / total MyISAM indexes: ".hr_bytes($myvar{'key_buffer_size'})."/".hr_bytes($mycalc{'total_myisam_indexes'})."\n";
-            push(@incvars,"key_buffer_size (> ".hr_bytes($mycalc{'total_myisam_indexes'}).")");
@@ -443 +445 @@
-        }
-    }
-    if ($mysqlvermajor > 3 && $myvar{'max_seeks_for_key'} > 1000) { push(@decvars,"max_seeks_for_key (<= 1000)"); }
-    
-    # Query cache
@@ -494 +495 @@
-    # Temporary tables
-    if ($mystat{'Created_tmp_tables'} > 0) {
-
+ && $mycalc{'max_tmp_table_size'} < 256
-            badprint "Temporary tables created on disk: $mycalc{'pct_temp_disk'}%\n";
-            push(@incvars,"tmp_table_size (> ".hr_bytes_rnd($myvar{'tmp_table_size'}).")");
-            push(@incvars,"max_heap_table_size (> ".hr_bytes_rnd($myvar{'max_heap_table_size'}).")");
-            push(@generalrec,"Be sure that tmp_table_size/max_heap_table_size are equal");
+            push(@generalrec,"Reduce your SELECT DISTINCT queries without LIMIT clauses");
+        } elsif ($mycalc{'pct_temp_disk'} > 25 && $mycalc{'max_tmp_table_size'} >= 256) {
+            badprint "Temporary tables created on disk: $mycalc{'pct_temp_disk'}%\n";
+            push(@generalrec,"Temporary table size is already large - reduce result set size");
-            push(@generalrec,"Reduce your SELECT DISTINCT queries without LIMIT clauses");
-        } else {
@@ -554 +559 @@
-        push(@generalrec,"Enable concurrent_insert by setting it to 1");
-    }
-0
-
+5
+%
-                push(@generalrec,"Your applications are not closing MySQL connections properly");
-        }