Changeset 11

Timestamp:

08/03/07 01:55:56 (1 year ago)

Author:

major

Message:

Added explanations for key max_connections and fixed a Plesk bug when you run the script as a non-root user

Files:

• mysqltuner.pl (modified) (8 diffs)

mysqltuner.pl

@@ -137 +137 @@
-my $mysqllogin;
-sub setup_mysql_login {
-f
+r
-        # It's a Plesk box, use the available credentials
-        $mysqllogin = "-u admin -p`cat /etc/psa/.psa.shadow`";
-        my $loginstatus = `mysqladmin ping $mysqllogin 2>&1`;
-        if ($loginstatus =~ /mysqld is alive/) {
-goodprint "Successfully logged into MySQL using Plesk's credentials.\n";
+# Login was successful, but we won't say anything to save space
-            return 1;
-        } else {
@@ -160 +160 @@
-                # Login was successful, but we won't say anything to save space
-            } else {
-                #badprint "Successfully authenticated with no password - SECURITY RISK!\n";
-                badprint "Successfully authenticated with no password - SECURITY RISK!\n";
-            }
@@ -176 +175 @@
-            my $loginstatus = `mysqladmin ping $mysqllogin 2>&1`;
-            if ($loginstatus =~ /mysqld is alive/) {
-
+
+
-                return 1;
-            } else {
@@ -289 +289 @@
-    #
-    # PER-THREAD BUFFERS:
-    #   binlog_cache_size - only if log_bin is 'ON' (default 32K)
-    my $binlog_cache_size = ($myvar{'log_bin'} =~ /ON/) ? $myvar{'binlog_cache_size'} : 0 ;
-    #   join_buffer_size - helps joins that don't use indexes (default 128M)
-    my $join_buffer_size = $myvar{'join_buffer_size'};
@@ -303 +301 @@
-    #
-    # PER-THREAD BUFFER CALCULATIONS:
- + $binlog_cache_size
+
-    my $total_thread_buffers = $thread_buffers * $myvar{'max_connections'};
-    my $max_thread_buffers = $thread_buffers * $mystat{'Max_used_connections'};
@@ -349 +347 @@
-            ") of physical memory (".hr_bytes($physical_memory).")\n";
-        $exptext = "Your current memory settings are reasonable as they do not exceed the maximum amount of memory on ".
-
+may not 
-            "available for the expansion of those buffers.";
-    }
@@ -408 +406 @@
-            "(".$mystat{'Max_used_connections'}."/".$myvar{'max_connections'}.")".
-            " - Increase the max_connections variable\n";
+            $exptext = "Your historical connection usage is too high relative to your set maximum.  The max_connections variable should be increased.";
-    } elsif ($connpct < 10) {
-        badprint "$connpct% of connections have been used ".
-            "(".$mystat{'Max_used_connections'}."/".$myvar{'max_connections'}.")".
-            " - Reduce max_connections\n";
+            $exptext = "Your historical connection usage is voo low relative to your set maximum.  MySQL is wasting resources by allowing".
+                " so many concurrent connections.";
-    } else {
-        goodprint "$connpct% of connections have been used ".
-            "(".$mystat{'Max_used_connections'}."/".$myvar{'max_connections'}.")\n";
+            $exptext = "These settings are appropriate for your historical usage.";
-    }
-    # If the back_log is less than 50, there's a chance that connections will be forcefully rejected
@@ -422 +424 @@
-        goodprint "Your listen queue back_log is set to a reasonable level (".$myvar{'back_log'}.")\n";
-    }
+    explainprint "You can currently handle ".($myvar{'max_connections'}+$myvar{'back_log'})." total connections, which includes ".
+        $myvar{'max_connections'}." active connections with ".$myvar{'back_log'}." more in queue. ".$exptext;
-}
-